-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-35594: [R][C++] Bump vendored date library #35612
Conversation
|
It seems like almost all of the files in https://github.com/apache/arrow/tree/main/cpp/src/arrow/vendored/datetime are from |
Indeed, it seems there are a couple other changes to include: $ git diff --stat 2e19c006e2218447ee31f864191859517603f59f cc4685a21e4a4fdae707ad1233c61bbaff241f93
include/date/date.h | 6 ++--
include/date/iso_week.h | 18 +++++++++---
include/date/ptz.h | 105 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------
include/date/tz.h | 4 +--
src/tz.cpp | 185 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------
test/iso_week/year.pass.cpp | 3 ++
test/testit | 6 ++++
7 files changed, 282 insertions(+), 45 deletions(-) |
I think I've got them all now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thank you @thisisnic !
There was an issue with tzdb 0.4.0 and the shipped arrow `tz.cpp`. This PR bumps the vendored version of the date library to commit `cc4685a21e4a4fdae707ad1233c61bbaff241f93`. * Closes: apache#35594 Authored-by: Nic Crane <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
@github-actions crossbow submit test-r-versions |
Revision: 2d79106 Submitted crossbow builds: ursacomputing/crossbow @ actions-bd3d5e4e25
|
There was an issue with tzdb 0.4.0 and the shipped arrow `tz.cpp`. This PR bumps the vendored version of the date library to commit `cc4685a21e4a4fdae707ad1233c61bbaff241f93`. * Closes: apache#35594 Authored-by: Nic Crane <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Benchmark runs are scheduled for baseline = f6e4479 and contender = aa057d0. aa057d0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
There was an issue with tzdb 0.4.0 and the shipped arrow `tz.cpp`. This PR bumps the vendored version of the date library to commit `cc4685a21e4a4fdae707ad1233c61bbaff241f93`. * Closes: #35594 Authored-by: Nic Crane <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
There was an issue with tzdb 0.4.0 and the shipped arrow
tz.cpp
.This PR bumps the vendored version of the date library to commit
cc4685a21e4a4fdae707ad1233c61bbaff241f93
.tz.cpp
#35594